parkhojeong commented on code in PR #65469:
URL: https://github.com/apache/airflow/pull/65469#discussion_r3247514050
##########
airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldSelector.tsx:
##########
@@ -127,6 +131,8 @@ export const FieldSelector = ({ name, namespace =
"default", onUpdate }: Flexibl
return <FieldObject name={name} namespace={namespace} onUpdate={onUpdate}
/>;
} else if (isFieldNumber(fieldType)) {
return <FieldNumber name={name} namespace={namespace} onUpdate={onUpdate}
/>;
+ } else if (isFieldDuration(fieldType, param.schema)) {
+ return <FieldDuration name={name} namespace={namespace}
onUpdate={onUpdate} />;
Review Comment:
Nit: It might be better to keep `isFieldDuration` next to the time checks
(`date`, `date-time`, `time`) so related fields are grouped together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
