vincbeck commented on code in PR #66976:
URL: https://github.com/apache/airflow/pull/66976#discussion_r3249396532
##########
providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio_notebook.py:
##########
@@ -77,6 +79,20 @@
project_id = test_context[PROJECT_ID_KEY]
notebook_id = test_context[NOTEBOOK_ID_KEY]
notebook_b_id = test_context[NOTEBOOK_B_ID_KEY]
+ # The DataZone StartNotebookRun API requires the caller to be the
environment's
+ # native user role. Configure a connection via environment variable.
+ # The role ARN is a static CDK parameter loaded into env by the test
runner.
+ import json as _json
+ import os
+ import urllib.parse
+
+ DATAZONE_CONN_ID = "aws_datazone_notebook"
+ _role_arn = os.environ.get("DATAZONE_ROLE_ARN", "")
Review Comment:
Something is off here, you are fetching this value for env variable although
you should get it using `test_context`
##########
providers/amazon/tests/system/amazon/aws/example_sagemaker_unified_studio_notebook.py:
##########
@@ -77,6 +79,20 @@
project_id = test_context[PROJECT_ID_KEY]
notebook_id = test_context[NOTEBOOK_ID_KEY]
notebook_b_id = test_context[NOTEBOOK_B_ID_KEY]
+ # The DataZone StartNotebookRun API requires the caller to be the
environment's
+ # native user role. Configure a connection via environment variable.
+ # The role ARN is a static CDK parameter loaded into env by the test
runner.
+ import json as _json
+ import os
+ import urllib.parse
Review Comment:
Move them at the top?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
