anishgirianish commented on PR #63491:
URL: https://github.com/apache/airflow/pull/63491#issuecomment-4461981791

   Thank you so much @ashb and @ferruzzi for the review! Latest push:
   
   - warn-once-per-class for all heartbeat-frequency compat shims 
(queued_tasks, queued_callbacks, supports_callbacks, trigger_tasks, 
order_queued_tasks_by_priority) so logs don't flood
   - __init_subclass__ shim for legacy supports_callbacks = True — synthesizes 
supported_workload_types + warns
   - newsfragment added
   - WORKLOAD_TYPE_PRIORITY typing fixed
   - TODO at executor_queues for the 4.0 flat-dict migration
   
   Two threads I'd love your steer on:
   
   1. Flat dict — went with the TODO-to-4.0 compromise. Happy to flatten now if 
you'd rather.
   2. CeleryKubernetesExecutor.queued_tasks — left as-is since __init__ raises 
on Airflow ≥3.0 making the new branch unreachable. Happy to migrate if you'd 
still prefer it.
   
   Would like to request your re-review. Will follow whichever way you'd both 
recommend. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to