choo121600 commented on code in PR #1524:
URL: https://github.com/apache/airflow-site/pull/1524#discussion_r3252168611
##########
landing-pages/site/assets/scss/_shared.scss:
##########
@@ -16,19 +16,9 @@
* specific language governing permissions and limitations
* under the License.
*/
- @import "media";
- .case-study-page {
- max-width: 790px !important;
- margin: 60px auto 0;
+@import "media";
- @media (max-width: $mobile) {
- margin-top: 40px;
- }
- }
-
- #case-studies-container {
- display: flex;
- justify-content: center;
- flex-wrap: wrap;
- }
+$navbar-height-desktop: 90px;
Review Comment:
Most usages of `$navbar-height-desktop` / `$navbar-height-mobile` are
outside the navbar component itself (`_base-layout`, `_header`,
`_four-oh-four`, `_roadmap`, `_community-page`, `_content-drawer`) and are
really describing a more general fixed-top-content offset.
Since this PR introduces the shared tokens, I think it's worth naming them
semantically now rather than renaming all the callsites later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
