justinmclean commented on code in PR #147: URL: https://github.com/apache/airflow-steward/pull/147#discussion_r3252567570
########## PRINCIPLES.md: ########## @@ -0,0 +1,117 @@ +<!-- Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. --> + +# Apache Steward Design Principles + +These principles regulate what this framework is and how it evolves. Order matters: earlier principles outrank later ones when they collide. Within the same family, the stricter reading wins until governance documents otherwise. + +A change (PR, skill, tool adapter, release) that violates a principle is wrong even if every test passes. Any committer may block it on principle grounds. The block lifts when the change complies, or when a principle-amendment proposal carries through governance with the same weight as a release vote. + Review Comment: Committer blocks have no resolution path. The preamble gives any committer the power to block a change on principle, but the amendment process grants binding votes only to PMC members. In ASF governance, these are distinct roles. So a committer can raise a block, but has no vote in resolving it — either the block is toothless (PMC overrides it anyway) or it's a deadlock with no exit. Suggest either: "any committer may raise a principle objection" (non-binding, for PMC consideration)" ########## PRINCIPLES.md: ########## @@ -0,0 +1,117 @@ +<!-- Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. --> + +# Apache Steward Design Principles + +These principles regulate what this framework is and how it evolves. Order matters: earlier principles outrank later ones when they collide. Within the same family, the stricter reading wins until governance documents otherwise. + +A change (PR, skill, tool adapter, release) that violates a principle is wrong even if every test passes. Any committer may block it on principle grounds. The block lifts when the change complies, or when a principle-amendment proposal carries through governance with the same weight as a release vote. + Review Comment: Committer blocks have no resolution path. The preamble gives any committer the power to block a change on principle, but the amendment process grants binding votes only to PMC members. In ASF governance, these are distinct roles. So a committer can raise a block, but has no vote in resolving it — either the block is toothless (PMC overrides it anyway) or it's a deadlock with no exit. Suggestion: "any committer may raise a principle objection" (non-binding, for PMC consideration)" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
