shahar1 commented on code in PR #66979:
URL: https://github.com/apache/airflow/pull/66979#discussion_r3252982423
##########
providers/google/src/airflow/providers/google/cloud/transfers/s3_to_gcs.py:
##########
@@ -165,7 +165,7 @@ def __init__(
replace=False,
gzip=False,
google_impersonation_chain: str | Sequence[str] | None = None,
- deferrable=conf.getboolean("operators", "default_deferrable",
fallback=False),
+ deferrable: bool = conf.getboolean("operators", "default_deferrable",
fallback=False),
Review Comment:
See my response to Wei's comment - conflict with an existing pre-commit that
specifically checks the deferrable kwarg to be assigned with
`conf.getboolean(...)` by default.
Adding the type hint works arounds it as it's not covered by the ruff rule
B008 (yet), but eventually we should think of another way to implement the
pre-commit to handle this case rather than checking against `conf.getboolean`
in the function's signature (see my
[comment](https://github.com/apache/airflow/pull/66979#discussion_r3249529100)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
