srchilukoori opened a new pull request, #67046:
URL: https://github.com/apache/airflow/pull/67046

   Fix broken download URLs and variable names in airflow-ctl 
installing-from-sources docs
   
   The `installing-from-sources.rst` page for airflow-ctl has two categories of 
bugs:
   
   **Broken URLs (HTTP 404)**
   
   The KEYS link and one of the curl commands use 
`downloads.apache.org/airflowctl/...`
   which doesn't exist. The correct base path is 
`downloads.apache.org/airflow/KEYS`
   (shared across all Airflow distributions) and 
`downloads.apache.org/airflow/airflow-ctl/{version}/`
   (matching the `base_url` already defined in `airflow-ctl/docs/conf.py` line 
210).
   
   The second curl command was slightly different — it used 
`downloads.apache.org/airflow/${version}/`
   but omitted the `airflow-ctl/` subdirectory.
   
   **Undefined shell variables**
   
   The bash verification script defines `ctl_download_dir` but then references 
two
   non-existent variables (`airflow_download_dir` and 
`airflowctl_download_dir`).
   Unified all references to `ctl_download_dir`.
   
   closes: #67025
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (Claude)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to