github-actions[bot] opened a new pull request, #67048: URL: https://github.com/apache/airflow/pull/67048
* Add static check ensuring trigger __init__ and serialize() stay in sync Trigger __init__ and serialize() are written as a pair: any __init__ parameter that serialize() does not return is silently dropped when the triggerer re-instantiates the trigger, falling back to the parameter's default. This adds an AST-based prek static check over provider triggers that flags such mismatches, resolving __init__/serialize() pairs through in-file base classes (including **super().serialize() spreads). Five existing violations are excluded as KNOWN_VIOLATIONS pending a follow-up fix; three by-design cases (deprecated/aliased params folded into their replacement at construction time) are permanently excluded. * Update scripts/ci/prek/check_trigger_serialize_init.py Co-authored-by: Wei Lee <[email protected]> * Rename noun-style helper functions to _get_/get_ form Rename based on Lee-W's review feedback: - _init_param_names → _get_init_param_names - _base_simple_names → _get_base_simple_names - _method → _get_method - _serialize_keys → _get_serialize_keys - _super_serialize_keys → _get_super_serialize_keys - violations → get_violations --------- (cherry picked from commit 49958a5000a25fe627efb42917d94240ba5bf4df) Co-authored-by: Shahar Epstein <[email protected]> Co-authored-by: Wei Lee <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
