Vamsi-klu opened a new pull request, #67052: URL: https://github.com/apache/airflow/pull/67052
Fix `CloudComposerDAGRunSensor` and `CloudComposerDAGRunTrigger` so they only succeed when at least one Dag run falls inside the requested execution window and every in-window run is in an allowed state. Why this change is needed: - the current window-checking helper returns success when no in-window Dag runs are found, as long as it also does not see an in-window disallowed state - that means unrelated out-of-window Dag runs can make the sensor succeed even though no relevant Dag run exists for the requested window - the same behavior exists in both the sync sensor and the deferrable trigger, so both paths need to be corrected together What changes in behavior: - if all returned Dag runs are outside the execution window, the sensor now waits instead of succeeding - if at least one Dag run is inside the window, success still requires all in-window runs to be in an allowed state - `composer_dag_run_id` behavior is unchanged - open-interval boundary behavior is preserved What is covered: - sync sensor unit tests for out-of-window, mixed-window, rejected in-window, and boundary-only cases - deferrable trigger unit tests for continued polling on out-of-window results and success on an in-window allowed run - system test example updated to use an explicit execution window so it does not rely on the previous false-positive behavior Follow-up: - the matching `CloudComposerExternalTaskSensor` and trigger anti-pattern is tracked in #67051 closes: #57512 --- ##### Was generative AI tooling used to co-author this PR? - [X] Yes — Codex (GPT-5) Generated-by: Codex (GPT-5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
