This is an automated email from the ASF dual-hosted git repository.
potiuk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow-steward.git
The following commit(s) were added to refs/heads/main by this push:
new fdf1b22 add License headers as a first-class review category (#187)
fdf1b22 is described below
commit fdf1b2223f2899f555478a8cd247464b9f4c9735
Author: Justin Mclean <[email protected]>
AuthorDate: Sun May 17 20:50:36 2026 +0800
add License headers as a first-class review category (#187)
---
.claude/skills/pr-management-code-review/criteria.md | 1 +
.../skills/pr-management-code-review/review-flow.md | 18 +++++++++++-------
.../_template/pr-management-code-review-criteria.md | 1 +
3 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/.claude/skills/pr-management-code-review/criteria.md
b/.claude/skills/pr-management-code-review/criteria.md
index 18af1ae..c11ea53 100644
--- a/.claude/skills/pr-management-code-review/criteria.md
+++ b/.claude/skills/pr-management-code-review/criteria.md
@@ -61,6 +61,7 @@ The canonical category list:
- Database / query correctness
- Code quality
- Third-party license compliance
+- License headers
- Testing
- API correctness
- UI (React/TypeScript)
diff --git a/.claude/skills/pr-management-code-review/review-flow.md
b/.claude/skills/pr-management-code-review/review-flow.md
index 3fdaa41..8992346 100644
--- a/.claude/skills/pr-management-code-review/review-flow.md
+++ b/.claude/skills/pr-management-code-review/review-flow.md
@@ -226,13 +226,17 @@ match against are:
2. **Database / query correctness**
3. **Code quality**
4. **Third-party license compliance**
-5. **Testing**
-6. **API correctness**
-7. **UI (React/TypeScript)**
-8. **Generated files**
-9. **AI-generated code signals**
-10. **Per-area `AGENTS.md` rules** — anything specific to the
- touched tree (the per-PR `AGENTS.md` discovery in Step 2).
+5. **License headers**
+6. **Testing**
+7. **API correctness**
+8. **UI (React/TypeScript)**
+9. **Generated files**
+10. **AI-generated code signals**
+11. **Quality signals to check**
+12. **Commits and PRs** (newsfragments, commit messages, tracking issues)
+13. **Security model**
+14. **Per-area `AGENTS.md` rules** — anything specific to the
+ touched tree (the per-PR `AGENTS.md` discovery in Step 2).
For each finding, record:
diff --git a/projects/_template/pr-management-code-review-criteria.md
b/projects/_template/pr-management-code-review-criteria.md
index 760e9c8..49a7105 100644
--- a/projects/_template/pr-management-code-review-criteria.md
+++ b/projects/_template/pr-management-code-review-criteria.md
@@ -89,6 +89,7 @@ These are used when the skill links out per-finding.
| Architecture boundaries |
`https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#architecture-boundaries`
|
| Database / query correctness |
`https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#database-and-query-correctness`
|
| Code quality |
`https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#code-quality-rules`
|
+| License headers | `https://www.apache.org/legal/src-headers.html` |
| Testing |
`https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#testing-requirements`
|
| API correctness |
`https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#api-correctness`
|
| UI (React/TypeScript) |
`https://github.com/apache/airflow/blob/main/.github/instructions/code-review.instructions.md#ui-code-reacttypescript`
|
