potiuk commented on PR #66711:
URL: https://github.com/apache/airflow/pull/66711#issuecomment-4476156879

   @rusher This PR has been converted to **draft** because it has open review 
feedback plus a failing static check — see our [Pull Request quality 
criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria).
   
   **Issues found:**
   - :x: **Pre-commit / static checks**: `CI image checks / Static checks` is 
failing. Run `prek run --from-ref main --stage pre-commit` locally and fix 
anything that flags. See the [static-checks 
docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst).
   - :warning: **Open review feedback from @jscheffl**: please respond to the 
[open 
thread](https://github.com/apache/airflow/pull/66711#discussion_r3215351511) 
about whether the two CLI options could be collapsed into one. Reply in-thread 
with your reasoning.
   - :warning: **Open Copilot review feedback**: 3 unresolved threads from 
Copilot (mostly around CTE grouping and in-place mock mutation) — please walk 
through each and either apply or reply with reasoning, then click "Resolve 
conversation".
   
   **What to do next:**
   - Fix static checks.
   - Respond to @jscheffl's design question and the Copilot threads.
   - Mark the PR as "Ready for review" when done.
   
   Converting a PR to draft is **not** a rejection — it is an invitation to 
bring the PR up to the project's standards so that maintainer review time is 
spent productively. No rush. If you have questions, feel free to ask on the 
[Airflow Slack](https://s.apache.org/airflow-slack).
   
   ---
   
   _Note: This comment was drafted by an AI-assisted triage tool and may 
contain mistakes. Once you have addressed the points above, an Apache Airflow 
maintainer — a real person — will take the next look at your PR. We use this 
[two-stage triage 
process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated)
 so that our maintainers' limited time is spent where it matters most: the 
conversation with you._
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to