jason810496 opened a new pull request, #67104:
URL: https://github.com/apache/airflow/pull/67104

   - related: https://github.com/apache/airflow/issues/65281
   - closes: https://github.com/apache/airflow/issues/61175
   - closes: https://github.com/apache/airflow/issues/53442
   - closes: https://github.com/apache/airflow/issues/56340
   
   ## Why
   
   ``[logging] logging_config_class`` is documented as a "Logging class" but 
actually resolves to a ``logging.config.dictConfig`` dict, and the 
``REMOTE_TASK_LOG`` / ``DEFAULT_REMOTE_CONN_ID`` side channel that powers 
remote log read-back was **undocumented**.
   
   So custom configs silently lost UI log read-back, and 
``ElasticsearchTaskHandler`` / ``OpensearchTaskHandler`` papered over it by 
self-registering from inside ``__init__``. The provider-side deprecation of 
that self-registration is split into follow-up PRs (one for ``elasticsearch``, 
one for ``opensearch``); this PR is the core/SDK/shared-library piece they 
depend on.
   
   ## How
   
   - Document the real contract for ``logging_config_class`` (dict, not class) 
and the ``REMOTE_TASK_LOG`` / ``DEFAULT_REMOTE_CONN_ID`` module-level 
attributes in the config option help, ``advanced-logging-configuration.rst``, 
and the ``discover_remote_log_handler`` docstring.
   - Add a startup ``WARNING`` for the case that "user module is missing 
``REMOTE_TASK_LOG`` while ``remote_logging`` is on". The warning is emitted 
from ``configure_logging`` **after** ``dictConfig`` runs, so the check sees the 
final state — important because the deprecated ES/OS self-registration path 
populates ``_ActiveLoggingConfig.remote_task_log`` from inside the handler 
``__init__``.
   - Drop the ``remote_logging_enabled`` parameter from 
``discover_remote_log_handler`` (no longer needed now that the warning lives in 
``configure_logging``).
   - Add unit tests for ``_warn_if_missing_remote_task_log``.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes, with help of Claude Code Opus 4.7 following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to