potiuk commented on PR #66218: URL: https://github.com/apache/airflow/pull/66218#issuecomment-4478997030
@tjhub1983 This PR has been converted to **draft** because it does not yet meet our [Pull Request quality criteria](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-quality-criteria). **Issues found:** - :x: **Pre-commit / static checks**: `CI image checks / Static checks` is failing. Run `prek run --from-ref main --stage pre-commit` locally and fix anything that flags. See the [static-checks docs](https://github.com/apache/airflow/blob/main/contributing-docs/08_static_code_checks.rst). - :x: **Build documentation**: `Build documentation (--docs-only)` and `Build documentation (--spellcheck-only)` are failing. Run `breeze build-docs` locally and fix the docs / spelling failures it surfaces. See the [docs-building docs](https://github.com/apache/airflow/blob/main/contributing-docs/11_documentation_building.rst). - :x: **Airflow CTL tests**: `airflow-ctl:P3.10 tests` is failing. Run `breeze testing airflow-ctl-tests` locally to reproduce. - :warning: **Open review feedback from @bugraoz93**: please respond to the open thread asking about endpoint structure / Pydantic datamodel use. Reply in-thread with your reasoning or push a fix. **What to do next:** - Fix the static-check and docs-build failures locally. - Make the airflow-ctl tests pass. - Respond to @bugraoz93's questions in the open threads. - Mark the PR as "Ready for review" when done. Converting a PR to draft is **not** a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. There is no rush — take your time and work at your own pace. We appreciate your contribution and are happy to wait for updates. If you have questions, feel free to ask on the [Airflow Slack](https://s.apache.org/airflow-slack). --- _Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this [two-stage triage process](https://github.com/apache/airflow/blob/main/contributing-docs/25_maintainer_pr_triage.md#why-the-first-pass-is-automated) so that our maintainers' limited time is spent where it matters most: the conversation with you._ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
