GitHub user Pedrinhonitz added a comment to the discussion: 
require_confirmation_dag_change need usecase/explanation

Hello, I saw the open forum and performed some tests, I hope this helps to 
understand.

I checked exactly version 2.10.4 of airflow and with the parameter 
AIRFLOW__WEBSERVER__REQUIRE_CONFIRMATION_DAG_CHANGE, in fact, in /home where we 
list the DAGs the alert does not appear, however if you click on the DAG to 
open it (View the /grid), the alert appears. Another important point I noticed 
is that if we have an airflow.cfg file, the following parameter needs to be 
added to it: require_confirmation_dag_change = True.

This implementation came from the following PR #38299, which makes it clear in 
the screenshots that it is developed only for the /grid pages of the DAG, and 
subsequently the following PR #42063, which was opened to correct a bug.

For Airflow 3.X, this has already been fixed and appears directly in the DAG 
listing on the home page and in the DAG grid. An important point is that for 
Airflow 3.X, the variable changes because the WebServer switches to the API 
Server, resulting in the variable being 
AIRFLOW__API__REQUIRE_CONFIRMATION_DAG_CHANGE.

I recommend updating to version 3.X if your environment is critical and 
requires the flag in the listing. Based on my research, there are no fixes for 
this in Airflow version 2.X, possibly due to the complex structure of (Flask + 
jQuery) making it difficult to implement without bugs. However, feel free to 
implement it if you wish.


Note: The documentation might be confusing because it doesn't explicitly state 
that it's for grid screens, and we could consider highlighting this point, as 
the end user might assume it applies to all screens.

However, note that in the PR, the author himself states the following:

"
However, when a user sets this configuration to True, **the Dag screen 
(Dag.html)** will enforce a logic that requires users to confirm before they 
can Trigger a DAG or Pause/UnPause a Dag.
" (`the Dag screen (Dag.html)`)

GitHub link: 
https://github.com/apache/airflow/discussions/45852#discussioncomment-16979140

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: [email protected]

Reply via email to