dstandish commented on code in PR #63568:
URL: https://github.com/apache/airflow/pull/63568#discussion_r3269475541
##########
airflow-core/src/airflow/models/dagrun.py:
##########
@@ -1078,7 +1085,7 @@ def _emit_dagrun_span(self, state: DagRunState):
name=f"dag_run.{self.dag_id}",
start_time=int((self.queued_at or self.start_date or
timezone.utcnow()).timestamp() * 1e9),
attributes=attributes,
- context=context.Context(),
+ context=context.Context(), # maybe need to make optional!!!
Review Comment:
resolved
##########
task-sdk/tests/task_sdk/execution_time/test_task_runner.py:
##########
@@ -4722,6 +4727,111 @@ def test_operator_failures_metrics_emitted(self,
create_runtime_ti, mock_supervi
mock_stats.incr.assert_any_call("ti_failures", tags=stats_tags)
+class TestDetailSpan:
+ """Tests for the detail_span decorator / context manager."""
+
+ def _make_provider_with_detail_level(self, level: int):
+ """Return (provider, tracer, carrier) where the carrier encodes the
given detail level."""
+ exporter = InMemorySpanExporter()
+ provider = TracerProvider()
+ provider.add_span_processor(SimpleSpanProcessor(exporter))
+ t = provider.get_tracer("test")
+ carrier = new_dagrun_trace_carrier(task_span_detail_level=level)
+ return provider, t, exporter, carrier
Review Comment:
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
