potiuk commented on PR #216:
URL: https://github.com/apache/airflow-steward/pull/216#issuecomment-4493724003
Hi @justinmclean — heads-up: this PR currently shows as conflicting against
`main`.
The conflicts are in `tools/skill-validator/src/skill_validator/__init__.py`
and `tools/skill-validator/tests/test_validator.py` and overlap with merged
#220 ("detect Pattern 4 injection-guard callout"), which reorganised the
validator registry and the test suite in the same area.
I had a look at rebasing it on your behalf, but resolving how the new
validator from this PR should coexist with the Pattern 4 infrastructure feels
like a judgement call you should make rather than me guessing. Could you rebase
against latest `main` and resolve when you get a moment? Happy to re-review
once it's clean.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
