SkastVnT commented on code in PR #66895:
URL: https://github.com/apache/airflow/pull/66895#discussion_r3271461658


##########
providers/databricks/src/airflow/providers/databricks/hooks/databricks_sql.py:
##########
@@ -71,6 +74,35 @@ def _cancel():
     return timer, timeout_event
 
 
+def _format_query_tag_value(value: str) -> str:
+    """
+    Escape special characters and truncate a single query tag value.

Review Comment:
   Thanks, good point. I accepted the docstring suggestion to reference the 
Databricks QUERY_TAGS limits directly.
   
   For this helper, the scope is value formatting: values are truncated to the 
documented 128-character limit and escaped for the QUERY_TAGS string format. 
The generated Airflow tag keys are fixed strings, and user-provided tags are 
typed as dict[str, str | None].
   
   I’ll double-check the remaining documented limits against the current 
implementation and keep any follow-up changes minimal.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to