uranusjr commented on code in PR #64571:
URL: https://github.com/apache/airflow/pull/64571#discussion_r3272068224
##########
task-sdk/src/airflow/sdk/definitions/partition_mappers/temporal.py:
##########
@@ -44,13 +44,13 @@ class StartOfDayMapper(_BaseTemporalMapper):
class StartOfWeekMapper(_BaseTemporalMapper):
- """Map a time-based partition key to week."""
+ """Map a time-based partition key to the start of its week."""
Review Comment:
```suggestion
"""Map a time-based partition key to the start of the week."""
```
It’s unclear what _it_ means. (The partition key’s week? That does not make
sense; should be e.g. the start of the week that includes the partition key?)
It would be worthwhile to either describe this more here, or link it to
somewhere in documentation.
Same applies for StartOfMonthMapper.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
