Lee-W commented on code in PR #67164:
URL: https://github.com/apache/airflow/pull/67164#discussion_r3272675607
##########
task-sdk/src/airflow/sdk/definitions/partition_mappers/temporal.py:
##########
@@ -16,17 +16,27 @@
# under the License.
from __future__ import annotations
+from typing import TYPE_CHECKING
+
from airflow.sdk.definitions.partition_mappers.base import PartitionMapper
+if TYPE_CHECKING:
+ from pendulum import FixedTimezone, Timezone
+
class _BaseTemporalMapper(PartitionMapper):
+ """Base class for Temporal Partition Mappers."""
+
default_output_format: str
def __init__(
self,
+ *,
Review Comment:
I just added it newsfragment and description. Should we include it in 3.3.0
or 3.2.3? interface inconsistency can probably(?) be considered as a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]