amoghrajesh opened a new pull request, #67237:
URL: https://github.com/apache/airflow/pull/67237
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Fix to errors seen in:
https://github.com/apache/airflow/actions/runs/26144521163/job/76898272728?pr=67041
Example:
```bash
_________________________________________________________________
TestGetChatModel.test_dispatches_via_init_chat_model_with_api_key
____________________________________________________________________
[gw1] linux -- Python 3.10.20 /usr/local/bin/python3
/usr/python/lib/python3.10/unittest/mock.py:1376: in patched
with self.decoration_helper(patched,
/usr/python/lib/python3.10/contextlib.py:135: in __enter__
return next(self.gen)
/usr/python/lib/python3.10/unittest/mock.py:1358: in decoration_helper
arg = exit_stack.enter_context(patching)
/usr/python/lib/python3.10/contextlib.py:492: in enter_context
result = _cm_type.__enter__(cm)
/usr/python/lib/python3.10/unittest/mock.py:1431: in __enter__
self.target = self.getter()
/usr/python/lib/python3.10/unittest/mock.py:1618: in <lambda>
getter = lambda: _importer(target)
/usr/python/lib/python3.10/unittest/mock.py:1257: in _importer
thing = __import__(import_path)
E ModuleNotFoundError: No module named 'langchain'
```
The LangChain hook tests fail in CI with `ModuleNotFoundError: No module
named 'langchain'`. Langchain is an optional dep not installed in std test envs
like Non DB tests.
Add an autouse fixture that pre populates `sys.modules` with `MagicMock`
stubs for the relevant `langchain` modules before each test. This lets `@patch`
resolve its targets without `langchain` installed, while keeping all tests
always-running rather than skipping them.
The `TestLangChainHookInit`, `TestGetUiFieldBehaviour`, and
`TestResolveModelId` classes have no langchain dependency and they anyways
mocked most of it and are unaffected
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
