paultmathew commented on code in PR #67229:
URL: https://github.com/apache/airflow/pull/67229#discussion_r3277823740
##########
providers/amazon/src/airflow/providers/amazon/aws/triggers/eks.py:
##########
@@ -160,6 +161,7 @@ def __init__(
last_log_time=last_log_time,
logging_interval=logging_interval,
trigger_kwargs=trigger_kwargs,
+ execution_deadline=execution_deadline,
Review Comment:
Switched `EksPodTrigger` to forward base-trigger kwargs through `**kwargs`
(commit 8dfa1af373) rather than listing each parent parameter explicitly. This
mirrors `GKEStartPodTrigger` where `*args, **kwargs` get forwarded to
`super().__init__` directly.
The explicit kwarg list was readable as documentation of the supported
surface. I think `**kwargs` + the `KubernetesPodTrigger` docstring is a
reasonable substitute — but if you'd rather keep the explicit list and add a `#
use next version` marker in `providers/amazon/pyproject.toml`, happy to flip
back. Let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
