amoghrajesh commented on code in PR #67268:
URL: https://github.com/apache/airflow/pull/67268#discussion_r3280042956
##########
providers/amazon/tests/unit/amazon/aws/executors/aws_lambda/test_lambda_executor.py:
##########
@@ -181,9 +182,10 @@ def test_task_sdk_callback(self, mock_executor):
"""Test task sdk callback execution end-to-end."""
from airflow.executors.workloads import ExecuteCallback
- callback_id = "callback_123"
+ callback_id = CallbackKey(id="callback_123")
Review Comment:
```suggestion
callback_id = CallbackKey("callback_123")
```
##########
providers/amazon/tests/unit/amazon/aws/executors/aws_lambda/test_lambda_executor.py:
##########
@@ -25,6 +25,7 @@
from semver import VersionInfo
from airflow.executors.base_executor import BaseExecutor
+from airflow.models.callback import CallbackKey
Review Comment:
This was added in 3.3 so compat tests will fail for top level import. The
tests using this have been guarded to run on 3.3+ anyways, so pls move this
into those test functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
