amoghrajesh opened a new pull request, #67319:
URL: https://github.com/apache/airflow/pull/67319
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
### What
The task state core API PUT endpoint had no way to control key expiry. Any
key created or edited via the API (including the UI in development here:
https://github.com/apache/airflow/pull/67292) got `expires_at = Never`,
ignoring the configured `default_retention_days`. There was also no way to
update only a keys value without overwriting its expiry.
### Current behaviour
- `PUT /states/{key}` only accepts `{"value": "..."}`. All writes silently
set `expires_at = null` (never expire), regardless of `[state_store]
default_retention_days`. Editing an existing keys value wipes its expiry.
### Proposed change
Added `expires_at: AwareDatetime | None | Literal["default"] = "default"`.
Three behaviours:
- "default" applies `default_retention_days` config,
- null means never expire,
- an aware datetime is used as-is
`PATCH /states/{key}` — new endpoint that updates only the value of an
existing key. Expiry is always preserved. Returns 404 if key does not exist.
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
