dabla commented on PR #65480:
URL: https://github.com/apache/airflow/pull/65480#issuecomment-4519511397
> @dabla — all 3 changes addressed:
>
> 1. serialize() now uses
f"{self.**class**.**module**}.{self.**class**.**name**}"
> 2. Transfer logic moved to transfer() method on both SFTPHook and
SFTPHookAsync
> 3. Trigger now uses SFTPHookAsync.transfer() — _do_transfer removed
>
> Ready for re-review 🙏
Hello @sunildataengineer , if the addressed the remarks that I pointed out,
you should resolve those conversations to make clear you resolved them, this
makes it easier for us the reviewers, thx.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]