bbovenzi commented on code in PR #67253:
URL: https://github.com/apache/airflow/pull/67253#discussion_r3290829889


##########
airflow-core/src/airflow/ui/src/components/TriggerDag/TriggerDAGForm.tsx:
##########


Review Comment:
   ```
     const { control, handleSubmit, watch } = useForm<DagRunTriggerParams>({
       defaultValues,
       values: { ...defaultValues, conf },
       resetOptions: { keepDirtyValues: true },
     });
   ```
   
   
   Needing two useEffects shows us that there is a problem at the core of how 
we're handling this. Let's update our use of react-hook-form and then use just 
one useEffect to handle trigger again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to