bugraoz93 opened a new pull request, #67387:
URL: https://github.com/apache/airflow/pull/67387
…al, keep optional as --flag (#66768)
* airflowctl: make required CLI params positional, keep optional as --flag
Auto-generated commands such as ``airflowctl dags get-details`` now accept
required primitive parameters positionally:
airflowctl dags get-details my_dag_id
instead of the previous ``--dag-id my_dag_id`` form. Optional parameters and
booleans keep the ``--flag`` form.
This follows the dev-list lazy consensus on airflowctl parameter style.
A parameter is considered required when the operation method declares it
without a default and without ``| None`` in its annotation. Datamodel- expanded
body fields are unaffected — they are not "parameters of the operation method"
in this sense and continue to use ``--flag``.
* tests: tmp_path fixture for command-factory; positional form for
integration tests
Two follow-ups to the positional-required-args change:
- ``TestCommandFactory._save_temp_operations_py`` previously wrote a shared
``test_command.py`` in cwd; under pytest-xdist that file is raced by workers,
so ``next(arg for arg in jobs_list_args if ...)`` in one test could see content
written by another and raise ``StopIteration``. Helper now takes the per-test
``tmp_path`` and returns the full path. The classmethod ``teardown_method``
that removed the shared file is no longer needed (pytest auto-cleans
``tmp_path``).
- The Airflow CTL PROD-image integration tests still invoked converted
parameters with the old ``--flag value`` form (e.g. ``--variable-key=X``,
``--section X --option Y``, ``--dag-id=example_bash_operator``). Updated each
occurrence to the positional form that the regenerated CLI now expects.
Optional parameters (``--logical-date``, ``--run-after``, ``--is-paused``,
``--state``, ``--limit``, etc.) stay as ``--flag``.
---------
(cherry picked from commit ffa426b64d7d99a66482b817887ee74d399824c4)
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
