kaxil commented on PR #65751: URL: https://github.com/apache/airflow/pull/65751#issuecomment-4526458232
One nit on the issue linkage before merge: `closes: #65745` is misleading. The repro in that issue uses `return "g.path_a"` (absolute id). @joshOberhaus tried that exact repro on 3.2.1 and `path_b` skips as expected ([comment](https://github.com/apache/airflow/issues/65745#issuecomment-4338200248)), so the stated reproducer doesn't demonstrate this bug. The behavior other users in that thread are hitting (broken skipping with absolute IDs inside **mapped** TaskGroups) was traced by @martijn-exads to #62287's `xcom_map_index = ti.map_index if parent.is_mapped else -1` and is tracked separately in #67265 -- this PR doesn't touch that path. What this PR _does_ fix is real and worth landing on its own: relative ids returned from a branch callable inside a prefixed TaskGroup. Suggest changing `closes: #65745` -> `related: #65745, #67265` so neither issue gets auto-closed on merge -- #67265 still needs a separate fix. Not a blocker, just flagging before merge. cc @jscheffl since you've already approved. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
