shubhgurav0590 commented on PR #67369: URL: https://github.com/apache/airflow/pull/67369#issuecomment-4529752137
"After running CI I found my fix was incorrect — it created a DAG cycle (launch → inner_task → launch). I've reverted the change. After studying the full __exit__ method I need clarification before implementing the correct fix: The roots variable contains INTERNAL workflow tasks. The current code correctly makes them wait for launch (root_task.set_upstream(launch)). My one-line addition reversed this causing a cycle. My question: when external_task >> task_group is called after the with block, does Airflow not correctly connect external_task to the launch task as the group root? Or is the bug triggered by a different pattern — such as setting dependencies before the with block? A minimal reproduction example would help me implement the correct fix. Happy to implement once the correct approach is confirmed." -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
