andreahlert commented on code in PR #215:
URL: https://github.com/apache/airflow-steward/pull/215#discussion_r3296413887
##########
tools/skill-validator/src/skill_validator/__init__.py:
##########
@@ -403,7 +480,7 @@ def extract_headings(text: str) -> set[str]:
# or attacker-controlled content.
_BODY_INLINE_RE = re.compile(r'--body[\s=]["\']')
-_FENCED_CODE_RE = re.compile(r"^```[\s\S]*?^```", re.MULTILINE)
+_FENCED_CODE_RE = re.compile(r"^[ \t]{0,3}```[\s\S]*?^[ \t]{0,3}```",
re.MULTILINE)
Review Comment:
One leftover from the round-2 review: the fence regex still allows tab
indentation.
```suggestion
_FENCED_CODE_RE = re.compile(r"^ {0,3}```[\s\S]*?^ {0,3}```", re.MULTILINE)
```
CommonMark only allows 0-3 spaces (not tabs) for fence indentation. Harmless
in practice but worth tightening for spec parity. If you accept the suggestion,
GitHub commits it directly to the branch and the PR is good to go from my side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
