github-actions[bot] opened a new pull request, #67468:
URL: https://github.com/apache/airflow/pull/67468
The `milestone-tag-assistant.yml` workflow snapshots PR labels at the
`get-pr-info` job (via `listPullRequestsAssociatedWithCommit`) and then
spends ~1.5 minutes installing Breeze and running `breeze ci
set-milestone`. If a maintainer adds and removes a backport label
inside that window, the action commits to the stale-snapshot decision
and sets the wrong milestone — see the incident on PR #67301 where a
backport label that lived for 49 seconds caused an Airflow-3.2.3
milestone to be set on a `main`-only documentation PR.
Re-read `issue.labels` from the freshly-fetched issue before computing
the milestone. If the labels changed since the snapshot:
- Honour any skip label that appeared after the snapshot.
- Re-run `_determine_milestone_version` with the current labels and
use the fresh decision; if the decision flips to "no milestone",
bail out before posting the comment.
Adds three regression tests covering the three race-window cases
(backport label removed, replaced, skip label added) and updates two
existing happy-path tests to populate `mock_issue.labels` so the
re-read sees the same labels as the snapshot.
(cherry picked from commit 6ecae6853e650fbcf8a67225eec8915eb91523f5)
Co-authored-by: Jarek Potiuk <[email protected]>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
