kaxil commented on PR #67429: URL: https://github.com/apache/airflow/pull/67429#issuecomment-4535292948
> The incremental flag for both datasources.refresh() and workbooks.refresh() has been supported in the Tableau Server Client (TSC) library since version 0.8.0, released in July 2018. This is wrong on every point: - `incremental` was added by [tableau/server-client-python#1545](https://github.com/tableau/server-client-python/pull/1545), merged 2024-12-13. - It first shipped in **TSC v0.35**, released [2025-01-06](https://github.com/tableau/server-client-python/releases/tag/v0.35). About 5 months ago, not 7+ years. - TSC v0.8 was actually released [2019-04-08](https://github.com/tableau/server-client-python/releases/tag/v0.8). The July 2018 release was v0.7. - The three links you posted are `vscode-file://` URIs pointing at VS Code's own Electron bundle on your local machine, not TSC docs. This matters for the PR because the provider currently pins [`tableauserverclient>=0.27, !=0.39`](https://github.com/apache/airflow/blob/main/providers/tableau/pyproject.toml#L66). After this change, every `method="refresh"` call passes `incremental=...` as a kwarg unconditionally, so any user on TSC 0.27-0.34 will hit `TypeError: refresh() got an unexpected keyword argument 'incremental'` even when they never set `incremental=True`. Either bump the min version to `>=0.35` in `pyproject.toml`, or only forward the kwarg when the user explicitly opts in. Also, honest question: did you actually test this against a Tableau Server, or is the PR (and this reply) generated by an LLM? A wrong version, a wrong release date, and fake `vscode-file://` "documentation links" is the exact failure mode of an unverified LLM answer, and it'd be better to know now than after merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
