Lee-W commented on issue #67368: URL: https://github.com/apache/airflow/issues/67368#issuecomment-4535488911
> I completely agree on dropping the back-fill. Only thing I'd love to keep is the "this run handled partition X" view, we could pull that from the AssetEvents instead, maybe as a small follow-up. Do you mean store this information in `DagRun.parition_key` or `AssetEvent.partition_key`? How would you like to express the idea that this run handles partition X, since it is decided at runtime and can have multiple values? Concatenation is probably one way, but not ideal 🤔 > On the manual-pk reject: I was poking around the trigger paths and got a little curious how you're picturing it landing. Looks like the public UI/REST trigger goes through create_dagrun directly while CLI/exec-API go via _trigger_dag, and create_dagrun is also where the scheduler/backfill set partition_key legitimately. Were you thinking one gated spot, or a check per path? Just want to make sure the UI trigger gets caught too. IIRC, the UI simply won't show the column if it's not a partitioned Dag (still need to handle the REST side though). but yep, if we could have a one gated spot, that would be awesome. But if it took us too much time to refactor, we could do a check per path and refactor later > +1 on the warn-and-ignore for alias add_partitions, and on rejecting for partitioned_at_runtime. We could probably do this at some point, but let's get other things done before we go back to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
