KarshVashi opened a new pull request, #67508:
URL: https://github.com/apache/airflow/pull/67508
Batch triggers (`BatchJobTrigger`, `BatchCreateComputeEnvironmentTrigger`)
did not forward
`verify` or `botocore_config` to the hook, so deferrable Batch operators
silently dropped
custom SSL and botocore settings when polling AWS from the triggerer.
Follows the same pattern established in the Lambda trigger migration
(`providers/amazon/src/airflow/providers/amazon/aws/triggers/lambda_function.py`).
**What this changes:**
- Adds `**kwargs` passthrough in both trigger `__init__` methods so
base-class params
(`verify`, `botocore_config`) reach `AwsBaseWaiterTrigger`
- Updates both `hook()` methods to pass `self.verify` and
`self.botocore_config` to
`BatchClientHook`
- Updates operator defer sites to forward `verify` and `botocore_config` to
the triggers
- Converts `BatchCreateComputeEnvironmentTrigger` call from positional to
keyword args
- Adds test coverage for serialization and hook propagation of both triggers
Part of #35278
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [X] Yes - Claude Code (Opus 4.6)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
