potiuk opened a new pull request, #67510:
URL: https://github.com/apache/airflow/pull/67510

   `GCSRemoteLogIO.hook` silently swallowed `AirflowNotFoundException` when the 
configured `remote_log_conn_id` did not exist, falling back to Application 
Default Credentials without any signal. That made a misconfigured remote-log 
connection (logs effectively going through the wrong credentials) invisible to 
operators — a security-control failure with no operational indication.
   
   Reported as F-008 in the [`apache/tooling-agents` L3 providers/google sweep 
`b1aec75`](https://github.com/apache/tooling-agents/issues/34).
   
   ## Change
   
   Replace the silent `pass` at 
[`gcs_task_handler.py:97-98`](https://github.com/apache/airflow/blob/main/providers/google/src/airflow/providers/google/cloud/log/gcs_task_handler.py#L97)
 with `self.log.warning` mentioning the unresolved `conn_id` so the fallback is 
visible in worker logs. Behaviour (falling back to ADC) is unchanged when no 
`remote_log_conn_id` is configured.
   
   ## Test plan
   
   - [x] `test_hook_warns_when_remote_log_conn_id_missing` — patches `GCSHook` 
to raise `AirflowNotFoundException`, asserts the warning is emitted with the 
unresolved conn_id name and `hook is None`.
   - [x] `test_hook_silent_when_no_remote_log_conn_id_configured` — empty 
conn_id means silent fall-through to ADC, no warning emitted.
   - [x] `prek run ruff` clean.
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes — Claude Code (Opus 4.7)
   
   Generated-by: Claude Code (Opus 4.7) following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to