justinmclean commented on PR #272:
URL: https://github.com/apache/airflow-steward/pull/272#issuecomment-4539887961
---
Pre-flight self-review — PR #272 (mentoring-prototype)
https://github.com/apache/airflow-steward/pull/272 · draft · author:
justinmclean
Base: main · Files changed: 3 (1 modified, 2 added) · Diff size: +33 / −2
Adds a single adversarial case (case-9-deprecation-decision) to the
existing
pr-management-mentor intervention suite plus the matching README count bump
(28 → 29; intervention suite 8 → 9). The case asserts that an out-of-scope
deprecation/removal request wins over draftable bug signals in the
trigger-priority logic — the contributor's "DeprecationWarning spam — can
we
just remove schedule_interval?" thread carries log-spam symptoms a mentor
could draft about, but the deprecation-decision ask triggers hand-off
(trigger
3), so action: "handoff", template: null.
Correctness
No findings. Math checks out (tone-checks 15 + hand-off 5 + intervention 9
=
29). expected.json field shape (action, template, reason) matches case-1
exactly. JSON valid; report.md mirrors the existing fixture format
(MaxAgentTurns, AgentCommentCount, OutOfScopeTopics, MaintainerLogins,
RecentMaintainerCommentCount). README inline description for case-9
("out-of-scope deprecation/removal decision carrying draftable bug signals
(hand-off still wins)") matches the expected reason semantics.
Security
No findings. Eval-fixture data only; no code, no shell, no network. The
fixture itself is an adversarial case for the skill it tests — that's its
job.
Conventions
No findings. markdownlint-cli2 clean on the 2 .md files. Both new files end
with \n. skill-validate --strict reports two violations in the run — both
pre-existing in security-issue-{triage,sync} (the gh-list-no-limit
warnings,
untouched by this PR).
Summary
Ready — no blocking or advisory findings.
Blocking: 0 Advisory: 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
