amoghrajesh commented on code in PR #67527:
URL: https://github.com/apache/airflow/pull/67527#discussion_r3301555953
##########
airflow-core/tests/unit/models/test_callback.py:
##########
@@ -109,13 +109,38 @@ def test_get_metric_info(self):
metric_info = callback.get_metric_info(CallbackState.SUCCESS, "0")
assert metric_info["stat"] == "deadline_alerts.callback_success"
+ # kwargs is JSON-stringified so non-primitive tag values don't crash
OTel
+ # (see test_get_metric_info_dict_values_are_stringified for the
regression).
Review Comment:
Cross ref adds no value, will be dead code if
`test_get_metric_info_dict_values_are_stringified` is renamed.
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
