minyeamer commented on PR #66809: URL: https://github.com/apache/airflow/pull/66809#issuecomment-4545703644
@bbovenzi I went through your requested changes and pushed follow-up commits to address them. The biggest change is that Mermaid now lives in a `MermaidProvider` under `src/context`, instead of being initialized from a standalone utility. That keeps theme initialization inside the React lifecycle while still lazy-loading Mermaid only when needed. Along the way, I also incorporated related feedback from the other threads: - reverted the syntax highlighter back to `PrismLight` - reduced the tests to minimal smoke coverage - limited math support to display math (`$$...$$`) and lazy-loaded KaTeX styles - added the required license notice updates I'm sorry for the late mention. After updating this branch from `main`, a few PROD image tests started failing, and I wanted to sort that out before asking for another look. Also, thanks to @potiuk for pointing out that I should mention the reviewer once the requested changes were addressed. I’ve resolved the threads I addressed. When you have a moment, could you please take another look and let me know if anything still needs adjustment? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
