Codingaditya17 commented on PR #67552:
URL: https://github.com/apache/airflow/pull/67552#issuecomment-4547489650
Thanks for the review. I updated the PR to move the normalization to the API
layer as suggested.
What changed:
- The grid API now serializes `None` child state keys as `"none"` instead of
emitting `"None"`.
- Updated the grid API response model to allow `"none"` as a child state key.
- Updated the existing grid API test expectations from `"None"` to `"none"`.
- Removed the frontend-only `"None"` normalization helpers and restored the
UI render sites to use the API-provided state key directly.
- Added `no_status` in `theme.ts` with the same gray semantic tokens as
`none`.
Tests run locally:
- `uv run pytest
airflow-core/tests/unit/api_fastapi/core_api/routes/ui/test_grid.py -k
"mapped"`
Result: `1 passed, 59 deselected`
- `cd airflow-core/src/airflow/ui && pnpm vitest run
src/utils/stateUtils.test.ts src/components/TaskInstanceTooltip.test.tsx`
Result: `Test Files 2 passed, Tests 17 passed`
- `uv run prek run ts-compile-lint-ui --all-files`
Result: `Compile / format / lint UI Passed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
