Codingaditya17 commented on PR #67550: URL: https://github.com/apache/airflow/pull/67550#issuecomment-4548057332
Good point, you were right. I updated the PR so pagination is now applied to distinct `ParseImportError.id` values first. After that, the route fetches all joined Dag rows for those paginated import-error IDs before grouping, so `limit` and `offset` apply to import-error objects instead of joined rows. I also extended the regression test to call the endpoint with `limit=1` and verify that the auth check still receives all 3 Dag rows for the file. Updated in `ce208ad6bf`. Local validation: `uv run pytest airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_import_error.py::TestGetImportErrors::test_total_entries_counts_distinct_import_errors_when_file_has_multiple_dags -q` Result: `1 passed, 1 warning` `uv run pytest airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_import_error.py -q` Result: `32 passed, 1 warning` `uv run prek run --files airflow-core/src/airflow/api_fastapi/core_api/routes/public/import_error.py airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_import_error.py` Result: mypy and formatting passed locally. The `generate-openapi-spec` hook could not complete in my local setup because my checkout path is also my `AIRFLOW_HOME`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
