m-rossi commented on PR #67535: URL: https://github.com/apache/airflow/pull/67535#issuecomment-4552505521
@potiuk You can simply test that my fix works by starting a Python shell where [python-ldap](https://github.com/python-ldap/python-ldap) is installed (for example your Airflow deployment of choice) and try ```python >>> import ldap >>> ldap.filter.escape_filter_chars Traceback (most recent call last): File "<stdin>", line 1, in <module> AttributeError: module 'ldap' has no attribute 'filter' ``` once you do my proposal, it works ```python >>> import ldap.filter >>> ldap.filter.escape_filter_chars <function escape_filter_chars at 0x7f469e678c20> ``` I found this solution in https://github.com/python-ldap/python-ldap/issues/469 and it is related how the package `python-ldap` is structured. I dig a little bit in the code and it seems like the `ldap.filter.escape_filter_chars` was introduced in https://github.com/apache/airflow/pull/66417 and seems we have no testing on this ldap-part of the code which may have caught this? So I ask you to reopen the PR and we should discuss about testing like @eladkal mentioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
