baolsen commented on a change in pull request #6886: [AIRFLOW-6327] http_hook: Accept json= parameter for payload URL: https://github.com/apache/airflow/pull/6886#discussion_r361948409
########## File path: airflow/hooks/http_hook.py ########## @@ -123,6 +127,7 @@ def run(self, endpoint, data=None, headers=None, extra_options=None): req = requests.Request(self.method, url, data=data, + json=json, Review comment: @dstandish I've changed my approach a bit - Now you'll see "**request_kwargs" which is more future proof. Another benefit is I could remove the changes to the slack_webhook tests. Would love to hear your thoughts :) I tried to add a test for the other kwargs supported by Requests but didn't manage to get it to work properly, and decided to leave it just testing the json= kwarg. Edit: Also finally figured out how rebase works, and cleaned up the commit history. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services