Miretpl commented on code in PR #67447:
URL: https://github.com/apache/airflow/pull/67447#discussion_r3313270441
##########
chart/newsfragments/67447.significant.rst:
##########
@@ -0,0 +1,3 @@
+Added support for configuring ``enableServiceLinks``.
Review Comment:
We could also add a deprecation warning for false values in the
`templates/NOTES.txt` file.
##########
chart/templates/workers/worker-deployment.yaml:
##########
@@ -157,6 +157,7 @@ spec:
terminationGracePeriodSeconds: {{
.Values.workers.terminationGracePeriodSeconds }}
restartPolicy: Always
serviceAccountName: {{ include "worker.serviceAccountName" . }}
+ {{- include "serviceLinks" . | nindent 6 }}
Review Comment:
We probably need this for pod-template-file too 🤔 (it is under `chart/files`
dir).
##########
chart/values.schema.json:
##########
@@ -226,6 +226,14 @@
"type": "string"
}
},
+ "enableServiceLinks": {
+ "description": "Enable kubernetes service links.",
+ "type": ["boolean", "null"],
+ "default": null,
+ "x-docsSection": "Kubernetes",
+ "$comment": "The default will become false in Chart 2.0"
+
+ },
Review Comment:
```suggestion
"enableServiceLinks": {
"description": "Enable Kubernetes service links. The default
will become false in Chart 2.0.",
"type": ["boolean", "null"],
"default": null,
"x-docsSection": "Kubernetes",
},
```
We don't have a rendering of the `$comment` field within the doc. In most
cases, we are just adding info in the description currently.
##########
chart/newsfragments/+b5a1f0bd.feature.rst:
##########
@@ -0,0 +1,3 @@
+Added support for configuring ``serviceAccountTokenVolume`` on the ``clean``
cronJob.
Review Comment:
Looks like wrong rebase/merge 🤔. Could you delete it as it is not related to
the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
