shahar1 commented on code in PR #67113: URL: https://github.com/apache/airflow/pull/67113#discussion_r3320616319
########## providers/google/tests/deprecations_ignore.yml: ########## @@ -57,6 +57,13 @@ - providers/google/tests/unit/google/cloud/hooks/test_bigquery.py::TestTimePartitioningInRunJob::test_run_query_with_arg - providers/google/tests/unit/google/cloud/hooks/test_bigquery.py::TestTimePartitioningInRunJob::test_run_with_auto_detect - providers/google/tests/unit/google/cloud/hooks/test_gcs.py::TestGCSHook::test_list__error_match_glob_and_invalid_delimiter +- providers/google/tests/unit/google/cloud/operators/test_bigquery.py::TestBigQueryCheckOperator +- providers/google/tests/unit/google/cloud/operators/test_bigquery.py::TestBigQueryCheckOperators Review Comment: duplicate of the above ########## providers/google/tests/unit/google/cloud/operators/test_bigquery.py: ########## @@ -2397,6 +2397,16 @@ def test_encryption_configuration_deferrable_mode(self, mock_job, mock_hook): class TestBigQueryCheckOperator: + def test_implicit_legacy_sql_default_warns(self): + with pytest.warns( + AirflowProviderDeprecationWarning, + match="The default value of `use_legacy_sql` is deprecated", + ): + BigQueryCheckOperator( + task_id="check_query", + sql="SELECT COUNT(*) FROM Any", + ) Review Comment: Could you please add tests to the other deprecated operators? ########## providers/google/src/airflow/providers/google/cloud/operators/bigquery.py: ########## @@ -64,6 +64,15 @@ from airflow.providers.google.common.hooks.base_google import PROVIDE_PROJECT_ID Review Comment: What about the hook? (it also utilizes the deprecated parameter) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
