ferruzzi commented on code in PR #67222:
URL: https://github.com/apache/airflow/pull/67222#discussion_r3320708911
##########
providers/amazon/src/airflow/providers/amazon/aws/utils/waiter_with_logging.py:
##########
@@ -87,11 +112,23 @@ def wait(
and isinstance(last_response.get("Error"), dict)
and "Code" in last_response.get("Error")
):
- raise AirflowException(f"{failure_message}: {error}")
+ error_code = last_response["Error"]["Code"]
+ if error_code not in RETRIABLE_ERROR_CODES:
+ raise AirflowException(f"{failure_message}: {error}")
+
+ log.info(
+ "Waiter encountered retriable error: %s. Retrying (attempt
%d/%d)...",
+ error_code,
+ attempt + 1,
+ waiter_max_attempts,
+ )
+ # Don't increment attempt counter for retriable errors;
continue looping
Review Comment:
Yeah, looks like if the service keeps returning a retriable error then this
will never exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
