[ https://issues.apache.org/jira/browse/AIRFLOW-5149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005346#comment-17005346 ]
ASF subversion and git services commented on AIRFLOW-5149: ---------------------------------------------------------- Commit eb8b49cf7129b9dc1c757fc4ae7c0cbeaed67b56 in airflow's branch refs/heads/v1-10-test from tooptoop4 [ https://gitbox.apache.org/repos/asf?p=airflow.git;h=eb8b49c ] [AIRFLOW-5149] - skip SLA checks config (#6923) * [AIRFLOW-5149] - skip SLA checks config (cherry picked from commit 7d97d16c47ba181839fd583b8653d2872dc4290b) > Config flag to skip SLA checks > ------------------------------ > > Key: AIRFLOW-5149 > URL: https://issues.apache.org/jira/browse/AIRFLOW-5149 > Project: Apache Airflow > Issue Type: Improvement > Components: DAG, DagRun, scheduler > Affects Versions: 1.10.4 > Reporter: t oo > Assignee: t oo > Priority: Minor > Fix For: 1.10.8 > > > Some airflow users have no use of managing SLAs within airflow. I believe the > scheduling process should be as fast as possible and not do unnecessary > logging, the current IF statement is slower than a boolean flag and produces > a redundant log. > h1. *EXISTING BEHAVIOR* > |if not any([isinstance(ti.sla, timedelta) for ti in dag.tasks]):| > | |self.log.info("Skipping SLA check for %s because no tasks in DAG have > SLAs", dag)| > | |return| > > h1. *FIX* > [https://github.com/apache/airflow/blob/master/airflow/jobs/scheduler_job.py] > within > |def _process_dags(self, dagbag, dags, tis_out):| > > line 1221 > *BEFORE* > self._process_task_instances(dag, tis_out) > self.manage_slas(dag) > > *AFTER* > 1. > self._process_task_instances(dag, tis_out) > if conf.getboolean('scheduler', 'CHECK_SLA'): > self.manage_slas(dag) > > 2. config then has a new variable check_sla with default true so existing > users unaffected but other users can set to false. > > > -- This message was sent by Atlassian Jira (v8.3.4#803005)