Lee-W opened a new pull request, #67718:
URL: https://github.com/apache/airflow/pull/67718

   ## Why
   
   `partition_key` semantics for `DagRun` and `AssetEvent` had three rough 
edges, all on unreleased AIP-76 behaviour (first ships in 3.2.0):
   
   - A task emitting outlet events could overwrite `DagRun.partition_key` via a 
runtime back-fill. That blurred ownership of the run's key — it should be 
provenance set by the scheduler / trigger side, not rewritten by task emission.
   - An outlet event emitted without an explicit key landed with `partition_key 
= None`, which left downstream partitioned consumers unable to route off it — 
even though the run it came from carried a key.
   - The REST trigger endpoint accepted a manual `partition_key` for Dags that 
are not partitioned at all, silently ignoring it.
   
   closes: #67368
   
   ## What
   
   - Drop the runtime back-fill in `register_asset_changes_in_db`. A task 
emitting outlet events no longer writes `DagRun.partition_key`; the run's key 
stays provenance-only, set by the scheduler / trigger side.
   - An `AssetEvent` emitted without an explicit `partition_key` now inherits 
the run's `partition_key` instead of staying `None`, so downstream partitioned 
consumers can route off it.
   - The REST trigger endpoint now rejects a `partition_key` for 
non-partitioned Dags with a `400` (Dags that are neither 
`timetable.partitioned` nor `timetable.partitioned_at_runtime`). The validation 
runs inside the route's error-handling block so the domain `ValueError` 
surfaces as `400` rather than `500`.
   
   All behaviour is unreleased, so the changes land in place with no 
compatibility shim and no newsfragment.
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [x] Yes (please specify the tool below)
   
   
   Generated-by: [Claude] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to