potiuk commented on a change in pull request #6950: [AIRFLOW-6392] Remove cyclic dependency baseoperator <-> helpers URL: https://github.com/apache/airflow/pull/6950#discussion_r362013100
########## File path: airflow/models/baseoperator.py ########## @@ -670,6 +672,7 @@ def __deepcopy__(self, memo): for k, v in self.__dict__.items(): if k not in shallow_copy: + # noinspection PyArgumentList Review comment: I am afraid so. The check is super useful because it detects spelling mistakes in parameters or removed parameters. This is actually a known problem because the memo parameter is by mistake missing in skeleton definition for python skeletons (from typeshed I believe). The issue is described here: https://intellij-support.jetbrains.com/hc/en-us/community/posts/360000181224-deepcopy-unexpected-memo-argument and reported here (unresolved): https://youtrack.jetbrains.com/issue/PY-29664 I have not found a good way of silencing it only for deepcopy, so I propose we can leave it as it is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services