Codingaditya17 opened a new pull request, #67763:
URL: https://github.com/apache/airflow/pull/67763
## What
This PR updates the Task Instance mark-as dialog so that the `downstream`
option is no longer selected by default.
## Why
In the Task Instances view, marking a failed task instance as success should
not automatically include downstream task instances unless the user explicitly
selects that option.
Previously, the dialog defaulted to `downstream`, which meant the request
was sent with `include_downstream: true`. This could cause downstream
`upstream_failed` task instances to be affected and resume within the same
DagRun, which differs from the older Airflow 2 Task Instances view behavior.
This change makes the action safer and more explicit: only the selected task
instance is updated by default, while users can still choose downstream
manually when they want that behavior.
## How
- Removed the default `downstream` selection from `MarkTaskInstanceAsDialog`
- Added a regression test to verify that `downstream` is not selected by
default
## Tests
cd airflow-core/src/airflow/ui
pnpm test MarkTaskInstanceAsDialog.test.tsx
Result:
✓ src/components/MarkAs/TaskInstance/MarkTaskInstanceAsDialog.test.tsx (1
test) 123ms
✓ MarkTaskInstanceAsDialog (1)
✓ does not select downstream by default 120ms
Test Files 1 passed (1)
Tests 1 passed (1)
uv run prek run ts-compile-lint-ui --all-files
Result:
Running hooks for `airflow-core`:
Compile / format / lint
UI...............................................Passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
