Vamsi-klu commented on PR #62343: URL: https://github.com/apache/airflow/pull/62343#issuecomment-4584957633
I found two blockers in the current head: 1. The worker success path drops team ownership when `commit_on_success=True` creates a brand-new connection. The public API resolves and authorizes the effective team, then stores it on `ConnectionTestRequest`, but `commit_to_connection_table()` creates the new `Connection(...)` without `team_name=self.team_name`. In multi-team mode that can turn a team-scoped connection credential into a persisted global connection. Please copy the team on creation and add a regression test for a new team-owned connection with `commit_on_success=True`. 2. The UI still appears to exercise the old synchronous API-server test path, so the main UI workflow does not get the worker-isolation behavior added by this PR. `useTestConnection.ts` still calls the generated client for `/api/v2/connections/test`, and that route still executes `conn.test_connection()` inside the API server process. If the intent is for UI connection tests to be isolated from the API server, the UI should enqueue the test and poll by token, or the old API-server route should be separately gated/deprecated so enabling connection testing does not keep exposing the synchronous API-server execution path. --- Drafted-by: Codex (GPT-5); reviewed by @Vamsi-klu before posting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
