jscheffl commented on code in PR #65469: URL: https://github.com/apache/airflow/pull/65469#discussion_r3330286758
########## airflow-core/src/airflow/ui/src/components/FlexibleForm/FieldDuration.tsx: ########## @@ -0,0 +1,76 @@ +/*! + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import { Input } from "@chakra-ui/react"; +import dayjs from "dayjs"; +import duration from "dayjs/plugin/duration"; +import { useTranslation } from "react-i18next"; + +import { paramPlaceholder, useParamStore } from "src/queries/useParamStore"; + +import type { FlexibleFormElementProps } from "."; + +dayjs.extend(duration); + +export const FieldDuration = ({ name, namespace = "default", onUpdate }: FlexibleFormElementProps) => { + const { t: translate } = useTranslation("components"); + const { disabled, paramsDict, setParamsDict } = useParamStore(namespace); + const param = paramsDict[name] ?? paramPlaceholder; + const handleChange = (value: string) => { + const isEmpty = value === ""; + const parsedValue = value.replaceAll(",", "."); + + if (paramsDict[name]) { + setParamsDict({ + ...paramsDict, + [name]: { + ...paramsDict[name], + value: isEmpty ? null : parsedValue, + }, + }); + } + + if (isEmpty) { + onUpdate(parsedValue); + + return; + } + const dur = dayjs.duration(parsedValue); + const isValid = !Number.isNaN(dur.asMilliseconds()); + + if (isValid) { + onUpdate(parsedValue); + } else { + onUpdate(undefined, translate("flexibleForm.validationErrorDuration")); Review Comment: One nit in validation: Compared to other fields even with invalid value the field let's you trigger the form (see trigger button is enabled): <img width="932" height="877" alt="Image" src="https://github.com/user-attachments/assets/c42427bd-9bbe-4bb2-afb4-c3494b1fad47"; /> See if other form field is invalid the trigger is disabled: <img width="926" height="873" alt="Image" src="https://github.com/user-attachments/assets/1270f87b-3109-4743-bbd4-d9209dd59a4f"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
